Bump axios to 1.20.0 and declare it as a direct dependency - #152
Open
rcooney-sh wants to merge 1 commit into
Open
rcooney-sh wants to merge 1 commit into
rcooney-sh wants to merge 1 commit into
Conversation
src/reporter.ts imports axios directly but it was only present as a peer dependency of axios-retry, pinned at 1.7.9 in package-lock.json. Declaring it explicitly and moving to ^1.20.0 picks up the fixes for AIKIDO-2026-10823 and the other 2025/2026 axios advisories. dist/ still needs to be regenerated with 'npm ci && npm run build' (requires BUF_TOKEN for the private buf registry) before merge so the shipped bundle picks up the new axios. Co-authored-by: Codesmith Staging <codesmith-bot@users.noreply.github.com>
rcooney-sh
marked this pull request as ready for review
September 3, 2026 22:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Security hygiene (vulnagent campaign 2026-09, group
hg_6196b8ec89ec8f04). Bumps axios from 1.7.9 to 1.20.0, which fixes AIKIDO-2026-10823 (first fixed in 1.16.1) and the other 2025/2026 axios advisories listed in triage.axios was only present as a peer dependency of axios-retry even though
src/reporter.tsimports it directly, so it is now declared explicitly:package-lock.jsonwas regenerated withnpm install --package-lock-only; only axios and its transitive closure changed (follow-redirects 1.16.0, form-data 4.0.6, and axios's proxy-agent helpers).Before this leaves draft
dist/.dist/index.jsstill bundles axios 1.7.9. It could not be regenerated by the agent because@buf/blacksmith_vm-agent.connectrpc_eslives on the private buf registry (needsBUF_TOKEN). A maintainer must runnpm ci && npm run buildon this branch and commitdist/. Until then the verify-build check fails by design.How to review:
package.jsonadds one line; the lockfile diff is mechanical. After the dist rebuild,grep -o 'const Ie="1\.[0-9.]*"' dist/index.js(the bundled axios version constant) should read 1.20.0.Risk level: medium
Breaking-change risk: axios 1.x keeps API compatibility; reporter.ts uses
axios.create, interceptors andAxiosError, and axios-retry's peer range (0.x || 1.x) still matches. Medium only because the shipped action bundle changes and CI (Node 16 in build/verify-build) must rebuild it; if Node 16 rejects any new transitive syntax, bump the workflows' Node version first.Validation: lockfile diff reviewed; no local build or tests (private registry). PR CI: build.yml runs
npm ci, build and jest; verify-build.yml gates on the committed dist matching a fresh build.Rollback: revert the commit(s) (package.json, package-lock.json, dist/). Consumers pinned to existing tags are unaffected until tags move.
Covered problems: prb_8c3e527b6c664882
Aikido findings: https://app.aikido.dev/issues/single/461280833
Linear: https://linear.app/blacksmith-sh/issue/SEC-690/medium-aikido-2026-10823
Note: the same problem also covers useblacksmith/setup-docker-builder (pnpm-lock axios 1.15.0, findings 461281113 and 461281157). That repo is not part of this group and needs a scoped follow-up.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is enabled. (Staging)Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is enabled.