feat(report): suppress findings from a baseline run - #904
Open
ousamabenyounes wants to merge 2 commits into
Open
feat(report): suppress findings from a baseline run#904ousamabenyounes wants to merge 2 commits into
ousamabenyounes wants to merge 2 commits into
Conversation
Contributor
Greptile SummaryAdds cross-run finding suppression using a prior run’s vulnerability report.
Confidence Score: 3/5The PR should not merge until baseline findings are restricted to deduplication and excluded from active-run listing, counts, and lookup. The combined getter is correctly useful for duplicate checks, but existing report-management callers also consume it, causing prior-run findings to be presented as current scan results. Files Needing Attention: strix/report/state.py Important Files Changed
Prompt To Fix All With AIFix the following 1 code review issue. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 1
strix/report/state.py:324
**Baseline findings pollute active reports**
When a baseline is configured, this getter returns baseline and current-run findings together; `list_reports` consequently includes prior-run findings in active totals and severity counts, while `get_report` can return a prior-run finding as though it belonged to the current scan.
Reviews (1): Last reviewed commit: "feat(report): suppress baseline run dupl..." | Re-trigger Greptile |
Contributor
Author
|
Fixed in 4f28417. Baseline findings now stay out of active report listing/lookup:
Validation: |
ousamabenyounes
force-pushed
the
fix/issue-900-baseline-run
branch
from
July 27, 2026 20:36
4f28417 to
e661212
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--baseline-run RUN_NAMEfor fresh scans, validated against./strix_runs/<run>/vulnerabilities.jsonbefore Docker/LLM startup.ReportStateas a separate non-persisted dedupe corpus for both CLI and TUI runs.baseline_runinrun.jsonso resumed runs keep the same known-findings baseline, and document the new CLI option.Fixes #900
Test verification (RED → GREEN)
RED, test-only on upstream
main:GREEN, after fix:
Focused regression suite:
Full suite:
Additional checks:
Known validation baseline: