feat(config): add per-request token budget - #909
Open
ousamabenyounes wants to merge 1 commit into
Open
Conversation
Contributor
Greptile SummaryAdds an optional positive per-request LLM output-token limit.
Confidence Score: 5/5The PR appears safe to merge with no actionable defects identified. The validated positive setting is resolved through the existing generic configuration path and forwarded into the single model configuration shared by root, newly spawned child, and resumed child agent requests. Important Files Changed
Reviews (1): Last reviewed commit: "feat(config): add per-request token budg..." | Re-trigger Greptile |
ousamabenyounes
force-pushed
the
feat/issue-231-token-budget
branch
from
July 27, 2026 20:37
01e59f0 to
31f88bd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #231.
Summary
STRIX_LLM_MAX_TOKENSas an optional positive integer setting.make_model_settingspath.Test verification (RED -> GREEN)
RED on
origin/mainwith only the helper regression test added:GREEN after the fix:
Fix-reverted proof:
Validation
uv run pytest tests/test_inputs.py tests/test_config_loader.py tests/test_runner_root_prompt.py tests/test_runner_rate_limit.py tests/test_models.py -q->117 passed, 2 warningsuv run ruff check strix/config/settings.py strix/core/inputs.py strix/core/runner.py tests/test_inputs.py tests/test_config_loader.py tests/test_runner_root_prompt.py tests/test_runner_rate_limit.py-> passuv run ruff format --check strix/config/settings.py strix/core/inputs.py strix/core/runner.py tests/test_inputs.py tests/test_config_loader.py tests/test_runner_root_prompt.py tests/test_runner_rate_limit.py-> passuv run mypy strix/config/settings.py strix/core/inputs.py strix/core/runner.py tests/test_inputs.py tests/test_config_loader.py tests/test_runner_root_prompt.py tests/test_runner_rate_limit.py-> passuv run bandit -q -c pyproject.toml strix/config/settings.py strix/core/inputs.py strix/core/runner.py-> pass