fix(tui): use running state for app lifecycle guards - #916
Open
ousamabenyounes wants to merge 1 commit into
Open
fix(tui): use running state for app lifecycle guards#916ousamabenyounes wants to merge 1 commit into
ousamabenyounes wants to merge 1 commit into
Conversation
Contributor
Greptile SummaryThis PR corrects TUI lifecycle guards to use the application running state.
Confidence Score: 5/5The PR appears safe to merge with no actionable correctness or security issues identified. The lifecycle changes consistently prevent application-level UI work after the Textual app has stopped, while existing widget mount checks continue to protect operations on individual widgets. Important Files Changed
Reviews (1): Last reviewed commit: "fix(tui): use running state for app life..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
self.is_mountedtruthiness guards withself.is_runningin the TUI lifecycle paths.widget.is_mountedsafety check unchanged.Closes #894.
Test verification (RED -> GREEN)
RED on
origin/mainwith only the regression test added:GREEN after the fix:
Local CI replay:
Known baseline: