OpenAI endpoint required toolchoice - #930
Closed
bearsyankees wants to merge 4 commits into
Closed
Conversation
…stom endpoints Reasoning models on OpenAI-compatible custom endpoints (e.g. GLM / Kimi) often reason and reply with prose instead of emitting native tool calls under the default auto tool choice, stalling the tool-driven scan loop while burning tokens. Default force_required_tool_choice to auto (None): enable tool_choice=required when an api_base is set (still gated to models that accept it), off otherwise. Explicit 0/1 overrides.
Contributor
Greptile SummaryThis PR automatically requires tool calls for OpenAI-compatible custom endpoints and preserves provider-reported OpenRouter streaming costs.
Confidence Score: 5/5The PR appears safe to merge, with no concrete changed-code defect identified. The endpoint-aware tool-choice behavior preserves explicit overrides and provider filtering, while the OpenRouter integration retains existing stream parsing and safely correlates exact costs under a lock. Important Files Changed
Reviews (1): Last reviewed commit: "fix(toolchoice): default required tool c..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.