Skip to content

fix: keep closing brackets when desyncing after a complete JSON array #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
detail-app wants to merge 1 commit into from
Closed

fix: keep closing brackets when desyncing after a complete JSON array #305

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions src/pipeline/frame_json_array.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,7 @@ pub const JsonArrayFramer = struct {
const byte = chunk[i];
i += 1;
if (isJsonWhitespace(byte)) continue;
try self.writeClose(out);
try self.enterDesync(out, chunk[i - 1 ..]);
return;
},
Expand Down Expand Up @@ -469,6 +470,23 @@ test "truncated input flushes buffered bytes and closes best-effort" {
try testing.expectEqualStrings("[{\"a\":1},{\"b\":]", got);
}

test "trailing junk after complete array keeps closing brackets" {
for ([_]usize{ 1, 7, 4096 }) |chunk| {
var sink: TestSink = .{ .allocator = testing.allocator };
defer sink.deinit();
const got = try runChunked("[1]extra", chunk, 64, &sink);
defer testing.allocator.free(got);
try testing.expectEqualStrings("[1]extra", got);
}
for ([_]usize{ 1, 7, 4096 }) |chunk| {
var sink: TestSink = .{ .allocator = testing.allocator };
defer sink.deinit();
const got = try runChunked("[](", chunk, 64, &sink);
defer testing.allocator.free(got);
try testing.expectEqualStrings("[](", got);
}
}

test "stats are accounted" {
const input = "[1,\"drop\",\"swap\",2]";
var sink: TestSink = .{ .allocator = testing.allocator };
Expand Down
Loading