feat(accessibility): Barrel Zoom for 3D shooters - #1741
Open
feilen wants to merge 3 commits into
Open
Conversation
Contributor
📝 WalkthroughWalkthroughAdds configurable barrel distortion to screen effects. The change updates UI controls, persisted settings, OpenGL and Vulkan rendering paths, JNI plumbing, native push constants, shaders, and native build configuration. ChangesBarrel distortion screen effect
Estimated code review effort: 4 (Complex) | ~45 minutes Sequence Diagram(s)sequenceDiagram
participant ScreenEffectsConfig
participant VulkanRenderer
participant vulkan_jni
participant VulkanRendererContext
participant VulkanShaders
ScreenEffectsConfig->>VulkanRenderer: Apply barrel distortion settings
VulkanRenderer->>vulkan_jni: Pass barrel distortion parameters
vulkan_jni->>VulkanRendererContext: Update native effect state
VulkanRendererContext->>VulkanShaders: Upload barrel push constants
VulkanShaders->>VulkanShaders: Compute and sample distorted UVs
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
feilen
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@app/src/main/java/app/gamenative/ui/component/ScreenEffectsPanel.kt`:
- Around line 895-897: Update ScreenEffectsPanel’s resetEffects() to also set
enableBarrelDistortion to false. In the rendered Column, add the
barrel-distortion ScreenEffectToggleRow and its matching AnimatedVisibility
slider block, mirroring the implementation in GLScreenEffectsTabContent or
ScreenEffectsTabContent so users can toggle and adjust the existing
barrel-distortion state.
In `@app/src/main/java/app/gamenative/ui/util/ScreenEffectsConfig.kt`:
- Around line 176-185: Update the barrel distortion branch in the apply logic to
retrieve the existing BarrelDistortionEffect through
composer.getEffect(BarrelDistortionEffect::class.java), falling back to a new
instance only when absent, then continue updating its strength, height, and
cylindricalRatio before adding it to effects.
In `@app/src/main/java/com/winlator/renderer/effects/BarrelDistortionEffect.java`:
- Around line 41-46: Update BarrelDistortionEffect.onUse so the height uniform
uses the same lower-bound-only behavior as VulkanRendererContext.setEffect:
clamp height to a minimum of 0.05 without imposing an upper bound. Leave the
strength and cylindricalRatio handling unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: f3da31c3-5e78-4c70-aa69-c8c5f338ef03
⛔ Files ignored due to path filters (2)
app/src/legacy/jniLibs/arm64-v8a/libvulkan_renderer.sois excluded by!**/*.soapp/src/modern/jniLibs/arm64-v8a/libvulkan_renderer.sois excluded by!**/*.so
📒 Files selected for processing (11)
app/src/main/cpp/winlator/VulkanRendererContext.cppapp/src/main/cpp/winlator/VulkanRendererContext.happ/src/main/cpp/winlator/vulkan_jni.cppapp/src/main/cpp/winlator/window.fragapp/src/main/cpp/winlator/window.vertapp/src/main/java/app/gamenative/ui/component/ScreenEffectsPanel.ktapp/src/main/java/app/gamenative/ui/component/dialog/ScreenEffectDialog.ktapp/src/main/java/app/gamenative/ui/util/ScreenEffectsConfig.ktapp/src/main/java/com/winlator/renderer/VulkanRenderer.javaapp/src/main/java/com/winlator/renderer/effects/BarrelDistortionEffect.javaapp/src/main/res/values/strings.xml
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 13 files
Tip: cubic used a learning from your PR history. Let your coding agent read cubic learnings directly with the cubic MCP.
Re-trigger cubic
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (1)
app/src/main/java/app/gamenative/ui/component/ScreenEffectsPanel.kt (1)
895-898: 🎯 Functional Correctness | 🟠 Major | ⚡ Quick winAdd the barrel-distortion controls to
ScreenEffectsPanel.This panel now loads, applies, persists, and resets barrel-distortion state, but its rendered toggle list still ends at NTSC. Users therefore cannot enable or adjust barrel distortion from this entry point; mirror the toggle and adjustment block already present in the sibling screen-effects composables.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@app/src/main/java/app/gamenative/ui/component/ScreenEffectsPanel.kt` around lines 895 - 898, Add the barrel-distortion toggle and adjustment controls to the rendered control list in ScreenEffectsPanel, following the existing implementation in the sibling screen-effects composables. Place them after the NTSC controls and bind them to the existing barrel-distortion state, ensuring users can enable, adjust, persist, and reset the values already handled by the panel.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@app/src/main/java/com/winlator/renderer/effects/BarrelDistortionEffect.java`:
- Around line 41-42: Remove the backticks surrounding the `@Override` annotation
in BarrelDistortionEffect.onUse so it is valid Java syntax and compilation
succeeds.
---
Duplicate comments:
In `@app/src/main/java/app/gamenative/ui/component/ScreenEffectsPanel.kt`:
- Around line 895-898: Add the barrel-distortion toggle and adjustment controls
to the rendered control list in ScreenEffectsPanel, following the existing
implementation in the sibling screen-effects composables. Place them after the
NTSC controls and bind them to the existing barrel-distortion state, ensuring
users can enable, adjust, persist, and reset the values already handled by the
panel.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 93f77d00-7ee5-4d4c-8df4-7e0b0f57ea8a
📒 Files selected for processing (3)
app/src/main/java/app/gamenative/ui/component/ScreenEffectsPanel.ktapp/src/main/java/app/gamenative/ui/util/ScreenEffectsConfig.ktapp/src/main/java/com/winlator/renderer/effects/BarrelDistortionEffect.java
🚧 Files skipped from review as they are similar to previous changes (1)
- app/src/main/java/app/gamenative/ui/util/ScreenEffectsConfig.kt
- Makes it more comfortable to play 3D or FPS games on a tiny screen! - Accessability feature which accepts strength, VFOV, and cylindrical ratio as tunables. - Allows for a sort of center-zoom which trends towards 'angle-area' to 'screen area' ratio being 1:1, instead of the sides of the screen taking up more space overall. - Hides all tunables when the feature is disabled - GL and Vulkan implementations - Currently does not compose with other screen effects meaningfully - probably could (need to think over which effects should go in what order - e.g. FXAA should go first but FSR should go after) - Does not remap mouse or touch input (doesn't matter for perspective-heavy games which typically use mouse-look/controller)
…istortion, align GL height clamp with Vulkan
…ke externalNativeBuild) the app/src/main/cpp/CMakeLists.txt is now wired into the build via externalNativeBuild in defaultConfig. cmake only builds the vulkan_renderer target (and its adrenotools/linkernsbypass deps) for arm64-v8a, skipping winlator and the hook targets. the prebuilt .so files in src/legacy/jniLibs and src/modern/jniLibs caused a duplicate with the cmake output, so they're removed.
feilen
force-pushed
the
feat/barrel-zoom
branch
from
August 10, 2026 01:41
86bd0a4 to
8233a6f
Compare
Author
|
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@app/build.gradle.kts`:
- Around line 121-127: Update the legacy and legacyXr build configuration around
externalNativeBuild so Vulkan cannot be selected for armeabi-v7a variants, or
ensure vulkan_renderer is built and packaged for that ABI. Preserve the existing
arm64-v8a Vulkan renderer configuration and align the flavor/ABI-specific
behavior with VulkanRenderer’s native library requirements.
In `@app/src/main/java/app/gamenative/ui/component/ScreenEffectsPanel.kt`:
- Around line 481-492: Update both OpenGL and Vulkan barrel-distortion
value-text sites in ScreenEffectsPanel.kt (anchor lines 481-492 and sibling
lines 786-797) to pass an explicit Locale.US to the String.format calls for
barrelDistortionFov and barrelDistortionCylindricalRatio, preserving their
existing numeric formats.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 924a5f96-0cdc-4233-8564-1a2942d757eb
⛔ Files ignored due to path filters (2)
app/src/legacy/jniLibs/arm64-v8a/libvulkan_renderer.sois excluded by!**/*.soapp/src/modern/jniLibs/arm64-v8a/libvulkan_renderer.sois excluded by!**/*.so
📒 Files selected for processing (7)
app/build.gradle.ktsapp/src/main/cpp/CMakeLists.txtapp/src/main/cpp/winlator/window.fragapp/src/main/java/app/gamenative/ui/component/ScreenEffectsPanel.ktapp/src/main/java/app/gamenative/ui/util/ScreenEffectsConfig.ktapp/src/main/java/com/winlator/renderer/effects/BarrelDistortionEffect.javaapp/src/main/res/values/strings.xml
🚧 Files skipped from review as they are similar to previous changes (4)
- app/src/main/res/values/strings.xml
- app/src/main/java/com/winlator/renderer/effects/BarrelDistortionEffect.java
- app/src/main/cpp/winlator/window.frag
- app/src/main/java/app/gamenative/ui/util/ScreenEffectsConfig.kt
Comment on lines
+121
to
+127
| externalNativeBuild { | ||
| cmake { | ||
| targets("vulkan_renderer") | ||
| arguments.add("-DSKIP_WINLATOR=ON") | ||
| abiFilters("arm64-v8a") | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
🩺 Stability & Availability | 🟠 Major | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# Trace Vulkan renderer loading and any ABI-specific availability checks.
rg -n -C 5 'loadLibrary\("vulkan_renderer"\)|VulkanRenderer|selectedRenderer|armeabi-v7a|abiFilters' \
app/src/main/java app/build.gradle.kts
# Find prebuilt Vulkan renderer libraries, if any.
fd -a 'libvulkan_renderer\.so' appRepository: utkarshdalal/GameNative
Length of output: 45002
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "== App package/build configs =="
fd -a 'AndroidManifest.xml' app | while read -r f; do
echo "--- $f"
rg -n 'package=|android:value=".*compat|android:value=".*selectedRenderer|selectedRenderer|vulkan|surfaceflinger|useGLRenderer|XR_BUILD' "$f" || true
done
echo
echo "== selectedRenderer/Vulkan init usages with context =="
rg -n -C 8 'new XServerView|XServerView\(|selectedRenderer|useGLRenderer|VR|VulkanRenderer|loadLibrary\("vulkan_renderer"\)' \
app/src/main/java/com/winlator/widget/XServerView.java \
app/src/main/java/app/gamenative/ui/screen/xserver/XServerScreen.kt \
app/src/main/java/app/gamenative/ui/component/QuickMenu.kt \
app/src/main/java/app/gamenative/ui/component/dialog/ScreenEffectDialog.kt \
app/src/main/java/com/winlator/container \
app/src/main/java/app/gamenative \
app/src/main/java/com/winlator/renderer
echo
echo "== Render mode/container fields =="
rg -n -C 4 'rendererPresentMode|rendererMode|Vulkan|glrenderer|GLRenderer|selectedRenderer' app/src/main/java/com/winlator/container app/src/main/java/app/gamenative/ui/app || true
echo
echo "== Native library files =="
fd -a 'libvulkan_renderer\.so' .Repository: utkarshdalal/GameNative
Length of output: 50379
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "== Container display renderer defaults/usages =="
rg -n -C 4 'displayRenderer|useGLRenderer|useLegacyRenderer|rendererPresentMode|setDisplayRenderer|setDisplayRenderer|XServerRendererView|loadLibrary\("vulkan_renderer"\)' \
app/src/main/java/com/winlator/container app/src/main/java/com/winlator \
| head -n 220
echo
echo "== Container constructors/defaulting =="
fd -a 'Container.java|Container.kt|.*Container.*' app/src/main/java/com/winlator app/src/main/java/app/gamenative | while read -r f; do
echo "--- $f"
rg -n -C 3 'displayRenderer|useGLRenderer|useLegacyRenderer|rendererPresentMode|containerRenderer|graphicsDriver|new Container|Container\(' "$f" || true
done | head -n 240
echo
echo "== XML manifests =="
for f in $(fd -a 'AndroidManifest.xml' app); do
echo "--- $f"
sed -n '1,220p' "$f"
doneRepository: utkarshdalal/GameNative
Length of output: 36756
Disable Vulkan renderer on legacy armeabi-v7a variants.
The legacy and legacyXr flavors still build armeabi-v7a, while vulkan_renderer is only built for arm64-v8a and VulkanRenderer loads libvulkan_renderer.so. When container.displayRenderer is vulkan on these 32-bit builds, XServerView instantiates VulkanRenderer before loading the native library, leaving the variant without a packaged backend and making Vulkan selection unrecoverable. Disable Vulkan for armeabi-v7a legacy builds, or build vulkan_renderer for that ABI.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@app/build.gradle.kts` around lines 121 - 127, Update the legacy and legacyXr
build configuration around externalNativeBuild so Vulkan cannot be selected for
armeabi-v7a variants, or ensure vulkan_renderer is built and packaged for that
ABI. Preserve the existing arm64-v8a Vulkan renderer configuration and align the
flavor/ABI-specific behavior with VulkanRenderer’s native library requirements.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Limitations
Recording
out.mp4
Type of Change
Checklist
#code-changes, I have discussed this change there and it has been green-lighted. If I do not have access, I have still provided clear context in this PR. If I skip both, I accept that this change may face delays in review, may not be reviewed at all, or may be closed.CONTRIBUTING.md.Summary by cubic
Add Barrel Zoom (configurable barrel distortion) to screen effects. Improves comfort for 3D/FPS on small screens by centering zoom and reducing edge stretch.
New Features
ScreenEffectsConfig.BarrelDistortionEffect; Vulkan addsEFFECT_MASK_BARREL_DISTORTION, extendsVulkanRenderer#setEffect(...)and JNI with barrel params; window shaders and push constants updated; color adjustments reapplied after distortion.Dependencies
externalNativeBuild(CMake) forvulkan_renderer(arm64-v8a) with-DSKIP_WINLATOR=ON; remove prebuiltlibvulkan_renderer.soto avoid duplicates.Written for commit 8233a6f. Summary will update on new commits.
Summary by CodeRabbit