Add Custom Domains migration#188
Conversation
Greptile SummaryThis PR introduces custom-domains migration by adding a new
Confidence Score: 5/5Safe to merge; the new domains migration path is well-isolated and follows established patterns throughout the codebase. No new defects are introduced. The source export, resource model, and destination dispatch are all correctly wired. The only pre-existing gap (GROUP_SETTINGS absent from extractServices) predates this PR and is not made worse here. The redirect-rule fallback for empty deploymentResourceType was flagged in a prior review cycle. src/Migration/Destinations/Appwrite.php — specifically the redirect-rule branch (already discussed in a previous review round). Important Files Changed
Reviews (5): Last reviewed commit: "Merge remote-tracking branch 'origin/add..." | Re-trigger Greptile |
…tom-domains-migration
- Transfer::extractServices match was missing GROUP_SETTINGS; callers hit the default 'No service group found' branch even though GROUP_SETTINGS_RESOURCES exists. - Destination's redirect-rule fanout called ProxyResourceType::FUNCTION() which the SDK generator renames to FUNCTIONMODEL() because FUNCTION is a PHP reserved keyword. Underlying value is still 'function'.
…tom-domains-migration
…tom-domains-migration
Summary
Resource::TYPE_RULEfor migrating custom-domain proxy rules.Sources/Appwrite) lists rules via the console SDK'sProxyservice, paginated with cursor.Destinations/Appwrite) dispatches to the SDK's four proxy-rule create endpoints (createAPIRule,createFunctionRule,createSiteRule,createRedirectRule) based on the rule'stype+deploymentResourceType..appwrite.networkrules are skipped — they're recreated automatically when the parent Function/Site is migrated.STATUS_WARNINGrather than aborting the migration, since the source must release the domain first.exportGroupDomainsin Firebase / NHost / JSON / CSV sources to satisfy the new abstract method.Test plan
testAppwriteMigrationCustomDomains(in appwrite/appwrite) passes