Skip to content

Added specification to doc directory#2017

Merged
vossmjp merged 9 commits intomasterfrom
dev/vossmjp/add_spec
Apr 15, 2026
Merged

Added specification to doc directory#2017
vossmjp merged 9 commits intomasterfrom
dev/vossmjp/add_spec

Conversation

@vossmjp
Copy link
Copy Markdown
Contributor

@vossmjp vossmjp commented Mar 17, 2026

Add specification to the doc directory along with support in make.bat to build it as part of the oneTBB documentation.

Adding additional files, such as change logs etc. can follow in other PRs.

Fixes # - issue number(s) if exists

Type of change

Choose one or multiple, leave empty if none of the other choices apply

Add a respective label(s) to PR if you have permissions

  • bug fix - change that fixes an issue
  • new feature - change that adds functionality
  • tests - change in tests
  • infrastructure - change in infrastructure and CI
  • documentation - documentation update

Tests

  • added - required for new features and some bug fixes
  • not needed

Documentation

  • updated in # - add PR number
  • needs to be updated
  • not needed

Breaks backward compatibility

  • Yes
  • No
  • Unknown

Notify the following users

List users with @ to send notifications

Other information

@vossmjp vossmjp marked this pull request as ready for review March 24, 2026 00:37
@vossmjp vossmjp requested review from isaevil and omalyshe March 24, 2026 00:37
@isaevil
Copy link
Copy Markdown
Contributor

isaevil commented Mar 24, 2026

Spellchecking scan has detected some spelling errors in the specification files. I'd suggest fixing them before merge.

Comment thread doc/main/reference/reference.rst Outdated
Comment thread doc/conf.py Outdated
.. |full_name| replace:: oneAPI Threading Building Blocks (oneTBB)
.. |short_name| replace:: oneTBB
.. |product| replace:: oneTBB
.. |tbb_version| replace:: 1.5
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we decide to keep it, I'd recommend renaming it to tbb_spec_version to avoid misunderstanding.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed it completely.

@vossmjp vossmjp requested review from kboyarinov and omalyshe April 10, 2026 15:47
kboyarinov
kboyarinov previously approved these changes Apr 10, 2026
Copy link
Copy Markdown
Contributor

@kboyarinov kboyarinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kboyarinov
kboyarinov previously approved these changes Apr 13, 2026
@omalyshe
Copy link
Copy Markdown
Contributor

@vossmjp Looks like we need to keep the original license in /specification folder https://github.com/uxlfoundation/oneAPI-spec/blob/main/LICENSE.rst

kboyarinov
kboyarinov previously approved these changes Apr 13, 2026
Copy link
Copy Markdown
Contributor

@kboyarinov kboyarinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vossmjp vossmjp merged commit 038ae18 into master Apr 15, 2026
26 checks passed
@vossmjp vossmjp deleted the dev/vossmjp/add_spec branch April 15, 2026 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants