chore: warn about deprecated packages instead of failing the update (#24619) (CP: 25.2)#24632
Merged
Conversation
…24619) (CP: 25.2) The frontend dependency update script previously exited with an error when deprecated packages were detected, preventing the update PR from being created. Now the script always completes and exports the deprecation details via GITHUB_ENV so the workflow appends them as a warning to the commit message of the generated PR.
Artur-
added
target/24.9
target/25.0
|
caalador
approved these changes
Jun 16, 2026
Collaborator
|
Hi @Artur- and @Artur-, when i performed cherry-pick to this commit to 25.0, i have encountered the following issue. Can you take a look and pick it manually? |
vaadin-bot
added a commit
that referenced
this pull request
Jun 16, 2026
…24619) (CP: 25.2) (#24632) (CP: 24.10) (#24643) This PR cherry-picks changes from the original PR #24632 to branch 24.10. --- #### Original PR description > The frontend dependency update script previously exited with an error when deprecated packages were detected, preventing the update PR from being created. Now the script always completes and exports the deprecation details via GITHUB_ENV so the workflow appends them as a warning to the commit message of the generated PR. > Co-authored-by: Artur Signell <artur@vaadin.com>
vaadin-bot
added a commit
that referenced
this pull request
Jun 16, 2026
…24619) (CP: 25.2) (#24632) (CP: 24.9) (#24644) This PR cherry-picks changes from the original PR #24632 to branch 24.9. --- #### Original PR description > The frontend dependency update script previously exited with an error when deprecated packages were detected, preventing the update PR from being created. Now the script always completes and exports the deprecation details via GITHUB_ENV so the workflow appends them as a warning to the commit message of the generated PR. > Co-authored-by: Artur Signell <artur@vaadin.com>
vaadin-bot
added a commit
that referenced
this pull request
Jun 16, 2026
…24619) (CP: 25.2) (#24632) (CP: 25.1) (#24642) This PR cherry-picks changes from the original PR #24632 to branch 25.1. --- #### Original PR description > The frontend dependency update script previously exited with an error when deprecated packages were detected, preventing the update PR from being created. Now the script always completes and exports the deprecation details via GITHUB_ENV so the workflow appends them as a warning to the commit message of the generated PR. > Co-authored-by: Artur Signell <artur@vaadin.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The frontend dependency update script previously exited with an error when deprecated packages were detected, preventing the update PR from being created. Now the script always completes and exports the deprecation details via GITHUB_ENV so the workflow appends them as a warning to the commit message of the generated PR.