feat: add PHP 8.5 support#79
Conversation
- Add PHP 8.5 to CI matrix in all three workflows (tests, phpstan, code style) - Upload coverage and test results to Codecov only from the PHP 8.5 job to avoid duplicate uploads - Widen phpstan phpVersion to a 8.4-8.5 range - Document tested PHP versions in README
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (5)
Walkthroughこのプルリクエストは、php-result ライブラリの CI/CD パイプラインを PHP 8.5 に対応させる一連の変更です。ワークフロー行列拡張、カバレッジ条件付き実行、静的解析設定更新、ドキュメント整備により、PHP 8.4 と 8.5 の両バージョンでの動作保証を実装しています。 ChangesPHP 8.4/8.5 マルチバージョン対応
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the README to indicate testing on PHP 8.4 and 8.5, and attempts to configure a range of supported PHP versions in phpstan.neon. However, the reviewer correctly noted that PHPStan's phpVersion parameter does not support an array structure with min and max keys, which will lead to a configuration error. It is recommended to revert this setting to a single integer representing the minimum supported version.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #79 +/- ##
===========================================
Coverage 100.00% 100.00%
Complexity 40 40
===========================================
Files 2 2
Lines 80 80
===========================================
Hits 80 80
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
There was a problem hiding this comment.
Pull request overview
Adds CI-level support for running this library on PHP 8.5 alongside PHP 8.4, aligning static analysis and documentation with the expanded tested PHP versions.
Changes:
- Expand GitHub Actions matrices to run tests, PHPStan, and code style checks on PHP 8.4 and 8.5.
- Avoid duplicate Codecov uploads by uploading coverage/test results only from the PHP 8.5 matrix job.
- Update PHPStan config and README to reflect/support the 8.4–8.5 tested range.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| README.md | Documents tested PHP versions in the requirements section. |
| phpstan.neon | Broadens PHPStan’s modeled PHP version range to cover 8.4–8.5. |
| .github/workflows/test.yml | Adds PHP 8.5 to the test matrix and gates Codecov uploads to a single matrix entry. |
| .github/workflows/phpstan.yml | Adds PHP 8.5 to the PHPStan workflow matrix. |
| .github/workflows/code-style.yml | Adds PHP 8.5 to the code-style workflow matrix. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ## Requirements | ||
|
|
||
| - PHP 8.4 or higher | ||
| - PHP 8.4 or higher (tested on PHP 8.4 and 8.5) |
| # Supported PHP versions (8.4 - 8.5) | ||
| phpVersion: | ||
| min: 80400 | ||
| max: 80500 No newline at end of file |
Summary
Add PHP 8.5 support to the CI pipeline while keeping PHP 8.4 supported (
composer.jsonconstraint^8.4already allows 8.5, so no change there).Changes
test.yml,phpstan.yml,code-style.yml): add'8.5'to the PHP version matrix — each workflow now runs on both 8.4 and 8.5test.yml: upload coverage and test results to Codecov only from the PHP 8.5 job to avoid duplicate uploads across matrix entriesphpstan.neon: widenphpVersionfrom80400to amin: 80400 / max: 80500range so analysis covers both supported versionsREADME.md: document tested PHP versions (8.4 / 8.5)Notes
src/only uses features stable on 8.5 (readonly classes,#[Override],nevertypes) with no deprecationsVerification
composer phpstan✅ /composer cs-check✅ /phpunit --no-coverage✅ (69 tests, 111 assertions)Summary by CodeRabbit
リリースノート