Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows backslash traversal and drive-relative paths could escape the profile directory through
ProfileScope.fileIn. Reject drive-relative paths and verify normalized path-component containment before returning the file, while retaining the existing API and valid root-relative behavior.Based independently on
webdav-syncat077f2e79; no storage refactor or settings UI changes are included.Validation with Flutter 3.44.8 / Dart 3.12.2 on Windows: 12 regression cases fail on the unchanged upstream code; all 31 focused tests pass with the fix. Changed-file analysis is clean. POSIX-host execution remains outstanding. The check is lexical containment and does not resolve filesystem links.
Independent adversarial review passed the 31 native Windows tests and 32 additional explicit path-context checks, including rejection of mutations to traversal and drive-relative handling. Explicit POSIX path contexts supplement coverage but do not replace native POSIX CI.
Combined validation with the other ten proposed slices: 304 focused/integration tests passed and an Android release build succeeded with Flutter 3.44.8 / Dart 3.12.2 / JDK 17. The test and build source trees match. The existing Windows Spotlight golden is excluded from that selection. A separate clean upstream full-suite run has 6,044 passes, 12 skips, 55 failing user tests and one failing teardown hook; this is not a full-suite or GitHub CI pass. Physical-device validation of the upstream ports remains outstanding.