Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the unchanged
PlaylistEntrydeclaration intolib/models/playlist_entry.dart, so other models no longer import a player-screen implementation directory. The original path re-exports the same declaration, preserving source compatibility and runtime type identity.Based independently on
webdav-syncat077f2e79. This changes two model imports and the ownership map; it does not change player behavior or require another refactor PR.Validation with Flutter 3.44.8 / Dart 3.12.2: all three original model contract tests pass before and after the move; two additional import-identity tests pass. Declaration bytes match upstream after line-ending normalization. Analysis adds no diagnostics; one existing
empty_catchesinformational diagnostic remains inseries_playlist.dart.Independent review found no production regressions. Two additional committed tests protect the former player-screen re-export and real-consumer type identity, bringing the final suite to seven passing tests. Removing the compatibility export is caught. Supplemental-test analysis is clean.
Combined validation with the other ten proposed slices: 304 focused/integration tests passed and an Android release build succeeded with Flutter 3.44.8 / Dart 3.12.2 / JDK 17. The test and build source trees match. The existing Windows Spotlight golden is excluded from that selection. A separate clean upstream full-suite run has 6,044 passes, 12 skips, 55 failing user tests and one failing teardown hook; this is not a full-suite or GitHub CI pass. Physical-device validation of the upstream ports remains outstanding.