Conversation
Validate the captured last-folder target against the visible flattened list rather than the end of the retained focus-node pool. Add the reproduced pointer-collapse regression test; all eight focused tests pass, with no new scoped analyzer diagnostics.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restore focus to the final folder row when navigating up from the PikPak folder picker's footer, including when that row is not currently mounted by the lazy list. Guard the pending reveal against cancellation, dismissal and empty results.
Based independently on
webdav-syncat077f2e79. The picker keeps its existing organization and selection behavior.Flutter 3.44.8 / Dart 3.12.2: three footer-navigation regression cases fail on upstream; all seven focused tests pass with the fix. Scoped analysis retains seven existing diagnostics. Physical-device validation is outstanding.
Independent review exposed a retained focus-node-pool edge case after collapsing loaded child folders. The follow-up guard uses the current visible folder index, with a committed regression test. A second verification of the corrected head passes all eight tests, including cancellation and dismissal.
Combined validation with the other ten proposed slices: 304 focused/integration tests passed and an Android release build succeeded with Flutter 3.44.8 / Dart 3.12.2 / JDK 17. The test and build source trees match. The existing Windows Spotlight golden is excluded from that selection. A separate clean upstream full-suite run has 6,044 passes, 12 skips, 55 failing user tests and one failing teardown hook; this is not a full-suite or GitHub CI pass. Physical-device validation of the upstream ports remains outstanding.