Conversation
Move ten unchanged JSON preference methods into a filter owner. Retain one captured profile across all five filter removals and the final provider removal, preserving failure order and public APIs.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the five default torrent-filter JSON encodings into a focused owner, retaining the existing StorageService APIs. Reset still captures one profile and removes the five filter keys followed by the provider key through that same preferences instance, even if the active profile changes during a write.
Validated independently against
webdav-syncat75b53ef3: 69 tests passed, four behavioral mutations caught, and no scoped analyzer diagnostics. Independent review reran all 69 tests and proved a provider-profile reacquisition mutation fails the reset assertions.The related profile-preferences suite retains its identical upstream subtitle save-receipt failure. No Settings layout, filter policy or provider behavior changes. This independent draft replaces only the default-filter storage slice of retired #61.