Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracts the two indexer configuration storage adapters from StorageService while preserving their public APIs. Canonical profile resources remain authoritative: saves return canonical readback, and settings reads keep the existing credential redaction rules. Legacy parsing and vault handling are unchanged.
Validated independently against
webdav-syncat75b53ef3: the same 58 tests pass before and after extraction. Mutations returning the original input instead of canonical readback and using execution authority for settings reads both fail their behavioral assertions. Scoped analysis reports no diagnostics. Independent review found no confirmed regression.No model, credential service, settings layout or caller changes. This independent draft replaces only the indexer-adapter slice of retired #61. Verification is focused tests and analysis; no real-provider or device test is claimed.