fix(llm): forward consolidation temperature - #3511
Open
lusoris wants to merge 1 commit into
Open
Conversation
Contributor
|
Checked exact head The remaining 3 temperature-pipeline cases stopped during fixture setup before exercising this patch because the local environment points at a SOCKS proxy without |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Forward
llm_temperature_consolidationto both observation-consolidation LLM calls:scope="consolidation")scope="consolidation_dedup")The configuration field and its environment resolution were added by #2469 for #2459. The current call sites do not pass the resolved value, so
HINDSIGHT_API_LLM_TEMPERATURE_CONSOLIDATIONhas no effect on these two operations. This also means the globalnonesetting cannot omit temperature consistently across all consolidation calls.Changes
Verification
pytest tests/test_consolidation_retry_budget.py tests/test_consolidation_dedup.py -q— 52 passed.pytest tests/test_consolidation.py::TestBuildResponseModel -q— 8 passed.pytest tests/test_llm_temperature_pipeline.py -q— 3 passed../scripts/hooks/lint.sh— passed.Risk
Low. This uses the existing resolved configuration and provider behavior. The default remains
0.0. A configuredNonecontinues throughLLMConfig.call()so providers can omit the parameter for models that reject explicit temperatures.Related
AI assistance
OpenAI Codex with the
gpt-5model, high reasoning, tool use, and code execution. The client does not expose the context-window size.