[CLI] Add a --trigger-mode full|delta flag to mental-models update - #3513
Open
mdbenito wants to merge 1 commit into
Open
[CLI] Add a --trigger-mode full|delta flag to mental-models update#3513mdbenito wants to merge 1 commit into
--trigger-mode full|delta flag to mental-models update#3513mdbenito wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
--trigger-mode full|deltatohindsight mental-model update, propagating it to thetrigger.modefield of thePATCHendpoint.Note that passing a trigger flag replaces the stored trigger configuration, so that unspecified trigger settings reset to their API defaults. I found this to be more consistent with the rest of the cli. Also, working around this behaviour of the PATCH endpoint would require a GET first.
The new flag composes with the existing
--trigger-refresh-after-consolidation.This PR also adds some test coverage for trigger override construction and serialization, a live round-trip integration test, and updates the OpenAPI coverage note.