fix: disable automatic cache affinity for Azure OpenAI - #3521
Open
koriyoshi2041 wants to merge 1 commit into
Open
fix: disable automatic cache affinity for Azure OpenAI#3521koriyoshi2041 wants to merge 1 commit into
koriyoshi2041 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
With the
openaiprovider and an*.openai.azure.combase URL, automatic cache affinity currently adds OpenAI'sprompt_cache_keyfield. Azure Foundry rejects that field withunrecognized_request_argument, breaking LLM-backed operations.Fixes #3518.
Fix
Remove Azure OpenAI hosts from the automatic
prompt_cache_keyallowlist. Native OpenAI andopenai.comhosts keep the existing behavior, while Azure hosts now resolveautotonone.The configuration and Azure setup docs now describe the same behavior.
Test
uv run pytest tests/test_cache_affinity.py -q— 67 passeduv run ty check hindsight_api/engine/cache_affinity.py hindsight_api/config.py— passedgit diff --check— passedThe repository-wide lint script reached the TypeScript lint step but could not load
@eslint/jsin this fresh worktree. No TypeScript files are changed by this PR.Risk
Low. This only narrows the
autohost allowlist. Operators who explicitly selectopenai_prompt_cache_keyretain that override, and non-Azure host behavior is unchanged.