Skip to content

fix Linux daemon PID lookup without lsof - #3523

Open
koriyoshi2041 wants to merge 1 commit into
vectorize-io:mainfrom
koriyoshi2041:fix/linux-port-pid-fallback
Open

fix Linux daemon PID lookup without lsof#3523
koriyoshi2041 wants to merge 1 commit into
vectorize-io:mainfrom
koriyoshi2041:fix/linux-port-pid-fallback

Conversation

@koriyoshi2041

Copy link
Copy Markdown
Contributor

Summary

  • fall back to ss when lsof cannot resolve a listening process on Linux
  • parse the listener PID from ss output
  • keep the existing macOS and Windows behavior

Fixes #3517.

Tests

  • uv run pytest tests/test_embed_manager.py -q (22 passed)
  • uv run ruff check hindsight_embed/daemon_embed_manager.py
  • uv run ruff format --check hindsight_embed/daemon_embed_manager.py tests/test_embed_manager.py
  • uv run ty check hindsight_embed/daemon_embed_manager.py
  • git diff --check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

_find_pid_on_port fails on Linux without lsof, producing "Could not find PID for port" warnings on every daemon stop

1 participant