Conversation
Signed-off-by: Dmitry Petrov <Komly@yandex.ru>
Signed-off-by: Dmitry Petrov <Komly@yandex.ru>
Contributor
|
@komly is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #3288.
A rejected dynamic skill resolver currently logs an error and lets the turn continue with the previous skill package. Resolver rejections now propagate, preserving the original cause. During an ordinary conversation turn, a
turn.startedfailure uses the existing recoverable turn-boundary path before the assistant model call; session-start failures stop initialization.All resolver outcomes settle before materialization. When any resolver rejects, none of that dispatch's skill updates are materialized. A later ordinary turn can resolve the repaired source in the same session.
The separate authorization-callback preamble emits lifecycle events outside the harness recovery path and can still terminate the session on resolver or authored-hook errors. This existing exception is documented, not changed here; it was traced in source rather than reproduced in a new runtime test.
Validation
pnpm --filter eve exec vitest run --config vitest.integration.config.ts src/context/dynamic-skill-errors.integration.test.ts.git diff --checkpass. Lint retains two pre-existing warnings in unrelated files.Checklist
CONTRIBUTING.mdevepackagegit commit --signoff)Diff size
Docs — 2 files ·
+7 / -0A release note and the dynamic-skills guide describe resolver failures and the existing recovery boundaries.
Implementation — 1 file ·
+5 / -8Routes rejected resolvers through the existing lifecycle error handling and removes the log-and-skip path.
Tests — 1 file ·
+159 / -0Uses a real filesystem source, sandbox, and session context to cover errors, preserved state, and later refresh without mocked resolvers or sandbox operations.