fix(eve): publish PR package artifacts automatically - #3358
Merged
Merged
Conversation
Signed-off-by: Andrew Barba <barba@hey.com>
Signed-off-by: Andrew Barba <barba@hey.com>
Contributor
Signed-off-by: Andrew Barba <barba@hey.com>
Contributor
|
I hit an error while handling your request (API key budget exceeded. Current spend: $754.28, limit: $750.00. Please contact your administrator to increase the budget.). Please try again, rephrase, or reach out if it keeps failing. Error id: 438c2c0d-ce09-4947-814b-040c3de5a216 |
Contributor
|
I hit an error while handling your request (API key budget exceeded. Current spend: $756.25, limit: $750.00. Please contact your administrator to increase the budget.). Please try again, rephrase, or reach out if it keeps failing. Error id: 042617f9-4b88-4def-aa1b-9a3b8b77bddc |
OwenKephart
approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR package publishing currently requires a manual workflow run, and that run rejects valid builds because it queries a workflow
statusas though it were aconclusion. This makes publication automatic for same-repository PRs after the credential-free build and reports a user-facingPackage artifactstatus only when the tarball is ready. Fork PRs are excluded from both package building and publishing, with a second trusted resolver check enforcing that boundary.The credentialed publisher remains a separate default-branch workflow so PR code cannot read the Blob token or alter publication logic. It revalidates the current branch or PR head immediately before updating its mutable pointer. Failed builds and publication failures report a failed package status rather than silently leaving users without a result.
Validation
pnpm --filter eve-package-artifacts test— 5 test files and 22 tests passed.docker run --rm -v "$PWD:/repo" -w /repo rhysd/actionlint:1.7.7 -color .github/workflows/build-tarball.yml .github/workflows/publish-tarball.yml— passed.pnpm exec oxlint apps/package-artifacts— passed with 0 warnings and 0 errors.pnpm exec oxfmt --check .github/workflows/build-tarball.yml .github/workflows/publish-tarball.yml apps/package-artifacts/README.md apps/package-artifacts/lib/publication-current.mjs apps/package-artifacts/lib/publication-current.test.mjs apps/package-artifacts/lib/publication-target.mjs apps/package-artifacts/lib/publication-target.test.mjs apps/package-artifacts/scripts/publish.mjs— passed.Checklist
CONTRIBUTING.mdevepackagegit commit --signoff)