feat: Support for mask-mode#752
Open
hex2f wants to merge 1 commit intovercel:mainfrom
Open
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for the mask-mode property, which controls whether a mask-image is interpreted as an alpha mask or a luminescence mask.
Implementation
parseMaskreadsmask-mode(and the-webkit- prefixedvariant) and stores it on the parsed mask, defaulting tomatch-source.buildMaskImageemitsmask-type="alpha"ormask-type="luminance"on the SVG mask element when explicitly set. Formatch-sourceno attribute is emitted, falling back to the default (luminance), preservingthe existing rendering behavior.
Following the existing convention in
parseMask(where position, size, repeat, origin, and clip apply as a single value to all layers),maskModealso applies once per element rather than per-layer. This maps cleanly onto SVGs per- mask-type attribute.Testing
I have added a test which checks that
mask-type=is properly applied to the SVG. There should probably be a pixel snapshot test added but I couldn't figure out how to do that, will add if required. All existing tests pass.