ci: run the Rust and Miri workflows only for main pushes and PRs - #172
Merged
Conversation
rust.yml and miri.yml had empty push/pull_request branch filters, so every push to a PR branch triggered both the push and the pull_request event (and tag pushes triggered extra runs), duplicating every check. Scope both to the main branch, matching llp.yml, so a pull request runs each check once.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rust.ymlandmiri.ymldeclared emptybranches:filters under bothpushandpull_request, so every push to a PR branch triggered both thepushand thepull_requestevent (and tag pushes triggered extra runs too), duplicating every Rust CI and Miri check.This scopes both workflows to the
mainbranch, matching the existingllp.yml, so a pull request runs each check exactly once (viapull_request) and only pushes tomainrun thepush-event checks.Follow-up to #171 (the empty filters predate it; this was noticed on that PR's duplicated runs).
llp.ymlalready used this pattern and was unaffected;build_artifact.ymltriggers only onreleaseand is untouched. This PR itself demonstrates the fix — Rust CI and Miri each trigger a singlepull_requestrun.