Skip to content

Translate the Windows notch placement settings into Russian - #274

Merged
vinzdg merged 1 commit into
vinzdg:mainfrom
unchase:fix/windows-settings-russian
Sep 20, 2026
Merged

vinzdg merged 1 commit into
vinzdg:mainfrom
unchase:fix/windows-settings-russian

Conversation

@unchase

@unchase unchase commented Sep 19, 2026

Copy link
Copy Markdown
Contributor

Summary

A Russian Settings window shows the notch placement rows in English: Edge with its four options and their captions, Screen, Main, and Show move handle with its caption. These strings reached the Chinese, Korean and Ukrainian tables, but not RU_STATIC.

Changes

  • windows/codenotch/ui/settings.html: add the 15 missing strings to RU_STATIC, using the terms the Russian table already uses (панель, край, карточка). Nothing else changes.

After this, every string the page shows has a Russian translation. The only keys still in other tables and not in RU_STATIC are two older wordings of the drag hint, which the page no longer shows.

Test Plan

  • node --check on the page script: passes.
  • Opened the page in a browser with a stubbed window.__TAURI__ and ru: the Appearance pane is fully Russian, with no console errors.
  • Built on Windows 11 and ran it.
  • The Screen row with more than one monitor: not seen, since this machine has one monitor.

🤖 Generated with Claude Code

Edge, its four options and their captions, Screen, Main and the move
handle row reached the other languages but not Russian, so a Russian
Settings window showed them in English.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@unchase
unchase requested a review from vinzdg as a code owner September 19, 2026 07:04
@vinzdg
vinzdg merged commit 38eba73 into vinzdg:main Sep 20, 2026
4 checks passed
@vinzdg

vinzdg commented Sep 20, 2026

Copy link
Copy Markdown
Owner

Merged as 38eba73. Thanks @unchase.

Heads-up on one thing I had to fix in the merge: #276 landed just before this and reworded two of the English sources you translated. 'Which screen the notch lives on. Dragging it onto another screen sets this too.' lost its second sentence, and the pill-drag hint was replaced wholesale by the Alt-drag one. Merged as written, those two Russian strings would have been dead keys rendering English. I re-pointed the first at the shortened source and dropped the second, since #276 already carries Russian for its replacement.

I also added a check across all six *_STATIC tables — RU_STATIC is now at 81 keys with nothing stale and nothing missing that the other locales have.

@unchase
unchase deleted the fix/windows-settings-russian branch September 20, 2026 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants