Conversation
Covers the tray menu, notch usage card, and Settings window: the STATIC_TEXT/TEXT/UI dictionaries in notch.html and settings.html, and the tr() table in i18n.rs. resolve_auto() already falls back to "pt" for a pt-* Windows locale.
|
Thanks @abrahaofv — the HTML half of this is good work. The Rust half is what holds it up, and it's visible on screen:
Two more before this can go in:
One you can leave to me if you'd rather: Heads up that |
|
@abrahaofv — closing this in favour of #300, which landed a few minutes ago. You had no way of knowing it existed; it was opened the day after yours, and I should have connected them sooner. The deciding factor is the one I raised with you yesterday: Beyond that, #300 carried the three things this one was missing, which I'd flagged: the It wasn't wasted: reviewing yours is what made me check the registration points properly, and #300 turned out to have a blocker of its own that I only looked for because of it — There is a real follow-up open if you want it, and it came out of your PR: |
|
Hi vinzdg,
I opened three small PRs and wanted to give you a quick rundown in one
place.
#318 — uk/ko static sweep
Follow-up on the review you left on #295. UK_STATIC was missing the two
#288 strings (Show move handle / the arc caption) — added them, transported
from the Mac catalog since the Ukrainian there is already authoritative.
Also dropped a dead key from UK_STATIC and KO_STATIC (the old Recentre
caption, superseded, no longer matched by any live text).
#319 — pt-BR terminology
Found while auditing #300 (not mine, but read through it closely).
PT_BR_STATIC called the pill "barra" in two places and "cápsula" everywhere
else, matching the Mac catalog; same story for "mouse" vs "cursor" on the
hover moment. Fixed the two outliers to match the rest of the file and the
Mac catalog. Flagged two other things in the PR body without touching them:
RU_STATIC/JA_STATIC missing a chunk of keys, and a wording divergence in
ZH_HANT_STATIC on the #288 pair.
#322 — topmost watchdog for #304
Implements the fix you and RawJat already worked out on the issue thread —
not a direction of my own, just wrote it up. Added topmost.rs: a 2s
watchdog that detects when the notch has left the topmost z-order band
(either WS_EX_TOPMOST cleared outright, or the bit set but an ordinary
window found ahead of it in z-order) and reasserts with a direct
SetWindowPos(HWND_TOPMOST, ...), bypassing tao's diffed set_always_on_top.
Also routed dropzones.rs's drag-carry lift through the same helper, since
that was the same no-op RawJat flagged. Tested by forcing the bug the way
the issue describes (SetWindowPos(HWND_NOTOPMOST) from outside the process)
and confirming recovery both in the log and visually, plus the drag-carry
scenario.
All three pass cargo test --locked (131/131) and cargo clippy with no new
warnings. Happy to adjust anything on any of them.
Thanks,
Abrahão
Em ter., 22 de set. de 2026 às 05:02, Vinz ***@***.***>
escreveu:
… *vinzdg* left a comment (vinzdg/codenotch#295)
<#295 (comment)>
@abrahaofv <https://github.com/abrahaofv> — closing this in favour of #300
<#300>, which landed a few
minutes ago. You had no way of knowing it existed; it was opened the day
after yours, and I should have connected them sooner.
The deciding factor is the one I raised with you yesterday: *pt-BR, not
pt.* The Mac catalog is filed under pt-BR, and the code is written into
lang in config.json, so picking the other one would have left the same
person on a different language across the two ports and stranded the saved
value if we changed it later.
Beyond that, #300 <#300> carried
the three things this one was missing, which I'd flagged: the traymenu.rs
arms (yours had none, so the tray stayed English above a translated card),
the five i18n.rs keys including quit_app and waiting, and the 13 Claude
sign-in strings in notch.html. It also uses Renovando/Renova rather than
Reiniciando/Reinicia — the mistranslation I mentioned.
It wasn't wasted: reviewing yours is what made me check the registration
points properly, and #300 <#300>
turned out to have a blocker of its own that I only looked for because of
it — pt-BR was missing from the LANGS whitelist, so the picker offered a
language it then silently discarded on save. I fixed that on merge.
*There is a real follow-up open if you want it*, and it came out of your
PR: UK_STATIC carries a dead key ("The pill can be dragged up and down
the right-hand edge…") that no longer matches any text in the page, and
both uk and ko are missing the two strings #288
<#288> added — Show move handle
and the arc caption. Those render English inside otherwise-complete
translations today. Small, real, and yours if you'd like it.
—
Reply to this email directly, view it on GitHub
<#295?email_source=notifications&email_token=AS72XGHRZABBNN3HUS5VSYD5QIWX3A5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKNZXGMYTAMZUGU3KM4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#issuecomment-5773103456>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AS72XGAMIVWSCJ2ZAB3MNLD5QIWX3AVCNFSNUABGKJSXA33TNF2G64TZHMYTGNJYGI4TKMZVGM5US43TOVSTWNJVGE4TSMJQHA4DPILWAI>
.
Triage notifications, keep track of coding agent tasks and review pull
requests on the go with GitHub Mobile for iOS
<https://github.com/notifications/mobile/ios/AS72XGBIGDZIDO6LWPLADBD5QIWX3A5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKNZXGMYTAMZUGU3KM4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJKTGN5XXIZLSL5UW64Y>
and Android
<https://github.com/notifications/mobile/android/AS72XGA7VKOEWY7IJLVCCUT5QIWX3A5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKNZXGMYTAMZUGU3KM4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLTGN5XXIZLSL5QW4ZDSN5UWI>.
Download it today!
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
Grato.
Abrahão Vendramini.
(21) 98313-2197
|
Summary
i18n.rs,ui/notch.html,ui/settings.html), matching the coverage already given toru/uk/ja/ko/zh/zh-Hant.resolve_auto()already falls back toptfor apt-*Windows locale; this fills in the actual translated strings and addsptto the language picker.Test plan
cargo build --releaseinwindows/codenotchcargo test— 126 passed, 3 ignored, 0 failed (includes a newportuguese_translates_every_known_keytest)node windows/scripts/check-ui-scripts.mjs— notch.html/settings.html inline scripts parse cleanly🤖 Generated with Claude Code