An account is called what its owner names it, everywhere at once - #327
Merged
Merged
Conversation
Two logins on one provider were told apart by their directory names: "Claude" and "Claude (work)". That is the machine's word for them. The pencil on a connected row in Accounts opens a name field; the name is kept in Preferences by provider id and the store writes it into every snapshot it publishes, so the notch, the menu bar, the cards and the notifications all use the same word as the row. Blank goes back to the provider's own name. Kept in Preferences and applied by the store rather than typed over in the row, because the row is the one place a name would otherwise be right while every other surface still said "Claude (work)". Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two logins on one provider are told apart by their directory names: "Claude" and "Claude (work)". That is the machine's word for them, not the person's.
Preferences.accountNicknames(by provider id) and applied byUsageStoreto every snapshot it publishes (nicknamesproperty, bound fromAppDelegate).ProviderSnapshot.displayNamebecomesvarfor that. So the notch, the menu bar, the hover cards and the notifications all use the same word as the row, and clearing the name restores the provider's own on the spot.Kept in Preferences and applied by the store rather than typed over in the row, because the row is the one place a name would otherwise be right while every other surface still said "Claude (work)".
On #321
#321 names a Claude ring after the signed-in address automatically. This is the manual layer above it: whatever
displayNamea provider computes stays the default and the placeholder in the field; a nickname wins only where one was typed. The two touch different code (ClaudeProfilethere,Preferences/UsageStore/AccountRowhere) and should merge in either order.Tests
AccountNicknameTests: the store renames what it has already published (snapshots and notch snapshots), clearing goes back to the provider's name, a name for another account changes nothing, the preference survives a relaunch, blank means no name, surrounding spaces are trimmed.make test: 1740 tests, 0 failures.🤖 Generated with Claude Code