Conversation
Co-authored-by: Codex <322868195+abrahaofvcodex@users.noreply.github.com>
Co-authored-by: Codex <322868195+abrahaofvcodex@users.noreply.github.com>
Co-authored-by: Codex <322868195+abrahaofvcodex@users.noreply.github.com>
|
Thanks @abrahaofv — and I'm sorry, because this is the second time this week you've hit a collision you had no way to see. I'm taking #320, which landed on the same idea a few hours earlier. The deciding difference is scope: #320 themes the Settings window and the drag overlay as well as the notch, and it sets the appearance before the window is built ( Two things in yours are better than what landed, and I'd like them:
One thing to know for next time: For the record, both of you independently solved the same real trap — the JS-drawn SVG arcs and card dots don't follow a CSS theme. Your |
The follow-up invited when #333 was closed. It fails on all four ways the theme can break, and deserialize_theme_or_system means a malformed theme no longer discards the rest of the config. Thanks @abrahaofv.
Summary
Scope
Windows only; the existing dark surface and its vivid usage palette remain the default.
Verification
ode scripts/check-ui-scripts.mjs
n- ode --test test-codex-headline.cjsn-ode --test scripts/test-ko-i18n.cjs
n- ode --test test-light-surface.cjsn- cargo test --locked (132 passed, 3 ignored)