Use newer JSON-P & JSON-B standards as alternative to Jackson, fixes #29#112
Draft
jwgmeligmeyling wants to merge 1 commit intovladmihalcea:masterfrom
Draft
Use newer JSON-P & JSON-B standards as alternative to Jackson, fixes #29#112jwgmeligmeyling wants to merge 1 commit intovladmihalcea:masterfrom
jwgmeligmeyling wants to merge 1 commit intovladmihalcea:masterfrom
Conversation
| * | ||
| * @author Jan-Willem Gmelig Meyling | ||
| */ | ||
| public class JsonNodeBinaryType extends AbstractHibernateType<JsonValue> { |
Owner
There was a problem hiding this comment.
This one is better named JsonValueBinaryType
| * @author Vlad Mihalcea | ||
| * @author Jan-Willem Gmelig Meyling | ||
| */ | ||
| public class JsonbJsonSerializer implements JsonSerializer { |
Owner
There was a problem hiding this comment.
We should have these classes in the jsonb/util folder as they are specific to JSON processing only.
Owner
|
Looks very good. You should definitely consider porting it. |
Contributor
Author
|
I’ll continue my work on the PR :) |
vladmihalcea
force-pushed
the
master
branch
from
f62b638 to
589e08d
Compare
vladmihalcea
force-pushed
the
master
branch
9 times, most recently
from
53bdf6c to
8135e13
Compare
vladmihalcea
force-pushed
the
master
branch
7 times, most recently
from
95ff7d1 to
29f8fd4
Compare
vladmihalcea
force-pushed
the
master
branch
5 times, most recently
from
b9f86b7 to
d20c417
Compare
vladmihalcea
force-pushed
the
master
branch
5 times, most recently
from
ccf829d to
df2f9c7
Compare
vladmihalcea
force-pushed
the
master
branch
3 times, most recently
from
a2224e9 to
ecf89dc
Compare
vladmihalcea
force-pushed
the
master
branch
2 times, most recently
from
aff9872 to
b7efcfb
Compare
vladmihalcea
force-pushed
the
master
branch
7 times, most recently
from
8f9b861 to
57d78d6
Compare
vladmihalcea
force-pushed
the
master
branch
5 times, most recently
from
a901c16 to
733fdde
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial implementation of #29. After approval of the overall structure, I will port the changes to the modules for Hibernate 5 and 4 too.