🌱 Update VM validation webhook to support multiple network providers#1663
Open
bryanv wants to merge 1 commit into
Open
Conversation
bryanv
force-pushed
the
bryanv/vm-validation-webhook-support-multiple-network-providers
branch
from
d4fed9e to
d4de60c
Compare
When a namespace has been migrated, the prior (legacy) provider must still be supported as to not break existing VMs or VKS clusters.
bryanv
force-pushed
the
bryanv/vm-validation-webhook-support-multiple-network-providers
branch
from
d4de60c to
0c83fc7
Compare
Minimum allowed line rate is |
faisalabujabal
approved these changes
Jun 16, 2026
| // global config value as a single-element slice; when enabled it fetches | ||
| // NetworkSettings/default from that namespace, returning the primary provider | ||
| // and, if set, the legacy provider as well. | ||
| func (v validator) getSupportedNetworkProviderTypes( |
Contributor
There was a problem hiding this comment.
this method is not really doing anything
| if networkKind != "" { | ||
| var supportedKinds []string | ||
| kindMatchesAny := false | ||
| for _, val := range validationsForKind { |
Contributor
There was a problem hiding this comment.
nit: we can use slices indexoffunc here especially. it would also exit early. i know that is not a concern because the slices are small, but a good convention to start following.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do, and why is it needed?
When a namespace has been migrated, the prior (legacy) provider must still be supported as to not break existing VMs or VKS clusters.
Which issue(s) is/are addressed by this PR? (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes # vmop-3880
Are there any special notes for your reviewer:
Please add a release note if necessary: