pmbasis linearized #41
Open
gilvillard wants to merge 21 commits into
Open
Conversation
Collaborator
Author
|
See comment close to nmod_poly_mat_shift_right(BT, B, nlo-degA); in middle_product.c, problem over there, certainly (ASan check failed) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New procedure
nmod_poly_mat_pmbasis_linearizedfromnmod_poly_mat_pmbasisby changing the matrix multiplications involved.Relies on new procedures for linearized matrix product.
Relies on #40 that seems to improve timings in the vast majority of cases.
nmod_poly_mat_mul_linearizedfor a product A(x).B(x), linearizes the columns of B into chunks of length related to the degree of A (to be tuned);nmod_poly_mat_middle_product_linearized, usesnmod_poly_mat_mul_linearized;nmod_poly_mat_mul_geometric;mbasisis now(order <= (ipmat->r))rather thanif (order <= PMBASIS_THRES)(to be tuned).The following tests give an idea of the range of superiority of
nmod_poly_mat_pmbasis_linearized. A comparison is also made withnmod_poly_mat_middle_product_geometricas only modification innmod_poly_mat_pmbasis.pmbasis linearized.pdf
Rider: adding a .h that had been forgotten for some of the prototypes in maple.