Open
Conversation
Collaborator
|
Rule not followed: 'The documentation is in English'; Which makes it really hard to review (for me) |
Author
|
This is a map component used in China, so the document content is all in Chinese |
Collaborator
|
Still, I cant judge the quality this way. |
Author
|
So, do I need to provide an English version of the readme or do I also need to translate the document into English? As the document is only provided to Chinese developers, translating English documents is meaningless to me and requires a lot of work |
Collaborator
|
An english readme would make it qualify yes. |
Author
|
Hello,I have added the English README, could you please take a look when you have time. |
Collaborator
|
Looks good |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GeneralTypeChecklistOpen SourceApps/Websites