Fix v1 instrumentation breaking if-else chains - #3
Open
kingkingkingson wants to merge 1 commit into
Open
Conversation
Inserting distance_instrument() before an else/else-if clause produces an 'else without a previous if' compile error; place the call inside the else block instead. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
instrument_v1insertingdistance_instrument()beforeelse/else if, which breaks the if-else chain and fails compilation withelse without a previous if.else, insert the call inside the else block (after{) instead.Test plan
locpoints at anelse ifline (e.g. libmingdecompile.cCVE-2018-8962) and confirm the generated source compiles.trigfuzz.driver --use-script --skip-fuzzon the swftocxx target.Made with Cursor