Conversation
tiero
reviewed
Oct 12, 2025
|
|
||
| func updateBinary(ctx *cli.Context) error { | ||
| // Get the update script URL from environment variable or use default | ||
| updateURL := os.Getenv("NIGIRI_TEST_UPDATE_SCRIPT_URL") |
Member
There was a problem hiding this comment.
Suggested change
| updateURL := os.Getenv("NIGIRI_TEST_UPDATE_SCRIPT_URL") | |
| updateURL := os.Getenv("NIGIRI_UPDATE_SCRIPT_URL") |
Member
|
I woudl have split in two PRs. Im not sure the hot loading of docker compose is that easy (if not pretty happy, but maybe we need a test) Also to stop --compose has to be passed right? otherwise can be some stale containers left. not sure how much liberty is good to give to user to pass anything that wont work with our curated compose as "template" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.