fix: parse repeated -e/--regexp/--file in zstdgrep - #1
Open
vulragrag-star wants to merge 1 commit into
Open
vulragrag-star wants to merge 1 commit into
vulragrag-star wants to merge 1 commit into
Conversation
Stop breaking after the first -e, and consume --regexp/--file (with and without '=') so later pattern options are not treated as files. Patterns live in grep_args; no positional pattern is stolen once any pattern option is seen. This is a small original evolution of the existing BSD zstdgrep script, not a reintroduction of the reverted gzip-zgrep-derived rewrite. See facebook#2064. Signed-off-by: Jason Wang <vulragrag@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Internal CI PR on fork for facebook#2064. Upstream later after cadence. Original BSD evolution; not gzip zgrep.