Fix tracestate key grammar tests#584
Merged
Merged
Conversation
SergeyKanzhelev
approved these changes
Jun 29, 2026
This was referenced Jul 4, 2026
bryannaegele
pushed a commit
to open-telemetry/opentelemetry-erlang
that referenced
this pull request
Jul 7, 2026
) The tracestate key regex in otel_tracestate implemented the obsolete Level 1 grammar with a separate tenant@vendor form. Trace Context Level 2 (w3c/trace-context#386) unified the grammar: key = ( lcalpha / DIGIT ) 0*255 ( keychar ) keychar = lcalpha / DIGIT / "_" / "-" / "*" / "/" / "@" so "@" is an ordinary key character, keys may start with a digit, and the only length limit is 256 characters total. The old regex rejected keys such as foo@, foo@@bar and foo@bar@baz, causing the whole tracestate header to be discarded. Verified against the W3C trace-context interop suite at HEAD (includes w3c/trace-context#584): all 41 tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #583