feat(core): allow keyboard press without a locate target - #2938
Merged
Conversation
Deploying midscene with
|
| Latest commit: |
31fdd7a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d2118b5f.midscene.pages.dev |
| Branch Preview URL: | https://fix-playwright-cut-shortcut.midscene.pages.dev |
quanru
force-pushed
the
fix/playwright-cut-shortcut
branch
2 times, most recently
from
August 12, 2026 07:35
dd44f9d to
c59890c
Compare
quanruzhuoxiu
changed the base branch from
main
to
fix/web-keyboard-focus-selection
August 12, 2026 07:36
Co-authored-by: quanruzhuoxiu <robin.lifeos@gmail.com>
quanru
force-pushed
the
fix/playwright-cut-shortcut
branch
from
August 12, 2026 07:51
c59890c to
31fdd7a
Compare
quanruzhuoxiu
changed the base branch from
fix/web-keyboard-focus-selection
to
main
August 12, 2026 07:52
EAGzzyCSL
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
aiKeyboardPresssignature to receiveundefinedas itslocateargumentlocatefor Copy or Cut after text has already been selectedaiAct-planned targetless Backspace with a generated reportScope
This PR targets
maindirectly and contains only the optional-locateAPI, planner guidance, documentation, and targetless tests. It does not contain thefocusElementimplementation or browser-side Cut command mapping from #2962.Validation
pnpm run lintpnpm exec nx build @midscene/corepnpm exec nx build @midscene/webpnpm exec tsc --noEmit -p packages/web-integration/tsconfig.jsonpnpm test -- tests/unit-test/action-keyboard-press.test.ts tests/unit-test/prompt/prompt.test.tsinpackages/core(46 tests passed)PUPPETEER_EXECUTABLE_PATH='/Applications/Google Chrome.app/Contents/MacOS/Google Chrome' pnpm test -- tests/unit-test/agent-keyboard-press-targetless-e2e.test.tsinpackages/web-integration(2 tests passed)Merge order
Merge this PR into
mainfirst. #2962 is an independent browser-side follow-up.