perf: skip disabled portable cache compare prep#14484
Draft
hardfist wants to merge 1 commit into
Draft
Conversation
Contributor
|
📝 Benchmark detail: Open
Base persistent cache hit rate: 👍 Current persistent cache hit rate: 👍 |
Contributor
📦 Binary Size-limit
❌ Size increased by 15.16MB from 52.77MB to 67.93MB (⬆️28.73%) |
Contributor
Merging this PR will not alter performance
Comparing 
Footnotes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Check Cache Portablecurrently runs after the Linux and Windows test jobs and still spends time checking out the repo, installing Rust, and downloading linux/windows cache artifacts. The actual compare command is disabled and the job only echoes success, so that preparation work is dead time at the end of the CI required-check path.Recent
mainCI runs show this job taking 85s (27733305620) and 71s (27734656396). Moving the placeholder job earlier and removing the unused artifact flow should remove roughly one minute from the CI tail without changing build or test coverage.What
Check Cache Portableaftercheck-changedon the mini Linux runner while the compare remains disabled.Impact
The portable cache comparison remains disabled before and after this change. Required test/build jobs still gate
Test Required Check; only the currently unused preparation work is removed.Checked locally with
prettier --check,git diff --check,actionlint, and anrgsweep for remainingtestCase-persistentCachereferences.