fix(agent): skip invalid JSON candidates - #2683
Open
alectimison-maker wants to merge 1 commit into
Open
Conversation
|
@alectimison-maker is attempting to deploy a commit to the esokullu's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates shared planner/classifier JSON extraction to skip malformed balanced objects and continue to the first valid object.
Changes:
- Continues scanning after
JSON.parsefailures. - Mirrors behavior across Chrome and Firefox.
- Adds regression coverage for both planners.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/chrome/src/agent/json-extract.js |
Adds resilient candidate scanning. |
src/firefox/src/agent/json-extract.js |
Mirrors Chrome parser behavior. |
test/run.js |
Tests malformed-candidate recovery. |
馃挕 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
JSON.parseProblem
Planner and classifier responses sometimes include an illustrative object before the final JSON result. When that first balanced candidate was not valid JSON,
extractFirstJsonObjectstopped scanning the candidate entirely, so a later valid plan was discarded.Testing
node test/run.js: 1450 passed, 1 pre-existing repository failure (package.jsonis26.0.10, newestCHANGELOG.mdentry is26.0.0)node test/security/injection-corpus.mjs: 60/60 checks passedScope
This does not relax plan validation or choose a later object when an earlier candidate is valid. It only advances after the earlier balanced candidate cannot be parsed as JSON.