fix: prompt saving issue #102#103
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Prompt instructions reverting to defaults after editing (#102)
Problem
Users reported that after updating prompt instructions, changes would not persist — they would revert
to the old/default instructions on next load.
Root Cause
In ThePopupBox.vue, the save and delete handlers mutated the prompt arrays in-place rather than
creating new references:
Since updateConfig uses a shallow spread ({...storedConfig, ...newConfig}) and the array reference is
unchanged, @plasmohq/storage does not detect a change and skips persisting it. On next load, the
previously stored (old) value is restored.
Additionally, store.ts initialized config with ref(defaultConfig) — sharing the same object reference
as the module-level default, meaning in-place mutations could also corrupt the defaults themselves.
Changes