ci: add PyPI publish attestations#179
Merged
Merged
Conversation
Owner
|
Thanks for the PR @shaanmajid. Seeing your change got merged in some other repos I'll trust this is a good change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hi! This switches the tag-only PyPI upload step from
uv publishtopypa/gh-action-pypi-publish@v1.14.0.junitparseralready publishes from GitHub Actions using PyPI Trusted Publishing/OIDC. Using the official PyPA publish action keeps that flow, but also generates and uploads PyPI publish attestations by default, so this should not require any new PyPI-side configuration or secrets.Those attestations bind each uploaded distribution to the trusted GitHub Actions publisher that uploaded it, making that provenance available through PyPI for downstream users and tooling.
This also removes the
uvsetup step from the publish job, since the upload step no longer usesuv.Possible follow-ups
I kept this PR intentionally small for reviewability, but noticed a few related release-hardening opportunities while looking at the workflow:
id-token: writeis only available in the final upload job.Testing
Not run; workflow-only change.