Fix screen scraping and codex sessions#51
Merged
Merged
Conversation
- Anchor generic_error regex to line-start structural shapes only (^error[:[] ^failed[:[] etc.) instead of bare substring matches. - Scope error detection to BaseKind::Other; agent sessions (Claude, Codex, LocalAgent) no longer flip to ERROR from screen text. - Add tests for anchored patterns and kind-scoped behavior.
- Report fresh input tokens (total minus cached) instead of raw cumulative, matching claude_log.rs behavior where cache reads are excluded from the displayed input count. Cache still prices into cost correctly. - Align tail() with claude_log accumulation pattern: track latest cumulative values in local acc_* variables and send one consolidated SessionStats per poll cycle instead of dispatching per-event.
When the TUI is on the alternate screen and content scrolls upward, capture the line leaving the top of the visible grid into output_lines for PageUp/Shift-Up scrollback. Gated to Claude/Codex sessions via captures_alt_scrollback() predicate; shell sessions unaffected. Dedup identical top lines to tolerate TUI repaints.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.