Conversation
Readable project and worktree suffixes could select the same network and mix service aliases. Include a stable checkout-path identity while preserving main-checkout names and leaving unrelated existing networks intact. Signed-off-by: Ueli Banholzer <ueli@whatwedo.ch>
xarem
force-pushed
the
fix/worktree-network-name-collisions
branch
from
September 16, 2026 13:33
9cf404a to
5c0d69e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A
featureworktree ofshopand the independentshop-featureproject currently select the same Docker network. Equally named worktree directories and names that sanitize to the same suffix can also mix application and database aliases.Append a stable 12-character hash of the project name and canonical checkout path to worktree network names. Creation, runtime overlays, and teardown continue to use the same naming function. Main-checkout network names remain unchanged, and switching branches in one directory retains its network identity.
Run
dde project:upto reconcile a running worktree with the new network name. Differently named networks are deliberately left alone because they may belong to other projects. The worktree guide, networking documentation, and bundled agent skill describe the naming contract.Validation: three new collision cases fail without the fix; lifecycle tests cover the new names; ECS, PHPStan level 8, Rector dry-run, and the full test suite pass (1,394 tests, 3 skipped).