Conversation
xarem
force-pushed
the
fix/worktree-traefik-network-label
branch
from
September 16, 2026 13:34
456431f to
c04a47f
Compare
Base and user override labels could overwrite the worktree network selected by dde. Drop inherited network labels case-insensitively so each worktree advertises only its own routing network. Signed-off-by: Ueli Banholzer <ueli@whatwedo.ch>
xarem
force-pushed
the
fix/worktree-traefik-network-label
branch
from
September 16, 2026 13:35
c04a47f to
d3704d2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An inherited
traefik.docker.networklabel can override the project network selected by dde when worktree labels are replaced with!override. The worktree then advertises a network it does not join.Exclude inherited network-selection labels, including differently capitalized spellings, from the worktree label copy. The runtime overlay remains the single source of truth while other user labels remain intact. Document this precedence in the worktree guide and Compose override contract.
Validation: regression cases for list/map labels and shell-less containers fail without the fix; ECS, PHPStan level 8, Rector dry-run, and the full test suite pass (1,393 tests, 3 skipped).