Conversation
Custom HTTP router and backend names remained shared with the main checkout even after their Host rules changed. Namespace those definitions and their local service references for containers that route project hostnames. Signed-off-by: Ueli Banholzer <ueli@whatwedo.ch>
xarem
force-pushed
the
fix/worktree-custom-traefik-names
branch
from
September 16, 2026 13:36
c90f13a to
08923fc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A custom router such as
webretains its identifier when dde rewrites its Host rule for a worktree. Main and worktree therefore publish conflicting router definitions; a custom backend name can also remain shared between checkouts.For containers routing project hostnames, prefix custom HTTP router and backend definitions with the worktree hostname and update references to those local backends. Keep hostname-derived identifiers on their existing rewrite path, preserve references to other providers, and leave containers that route only unrelated domains unchanged. The
dde-prefix keeps custom names separate from ordinary hostname-derived identifiers.Validation: custom-name regression cases fail without the fix; tests cover local/Docker and external-provider references, coexistence with generated names, metadata, and unrelated domains; ECS, PHPStan level 8, Rector dry-run, and the full test suite pass (1,394 tests, 3 skipped).