fix: sanitize step summaries used as file paths - #40
Closed
rubenfiszel wants to merge 1 commit into
Closed
rubenfiszel wants to merge 1 commit into
rubenfiszel wants to merge 1 commit into
Conversation
Step summaries are used as the source of truth for inline script file names via assignPath(). They were not sanitized, so summaries containing path separators (/, \) or OS-reserved characters could produce invalid or traversal-prone file paths. Wrap the path assigner to strip control characters, path separators, and reserved filename characters before path generation. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
assignPath()were not sanitized, allowing path separators (/,\), control characters, and OS-reserved characters (<>:"|?*) to end up in generated file pathssanitizePathSegment()infile-utils.tsthat strips these charactersextension.tsso summaries are sanitized before path generation, keeping both on-disk files and!inlinereferences consistentTest plan
sanitize-path.test.tswith 7 test cases covering normal passthrough, path traversal sequences, OS-reserved chars, control chars, empty strings, and all-bad-character stringsnpx jest)npx tsc --noEmit)🤖 Generated with Claude Code