chore(facade): point fe_facade_url at Web Host 1.0.56 - #110
Merged
Conversation
Bumps the CDN ref in all five files that carry it — `_index.yaml`, `Makefile` (`WEB_HOST_CDN`), `README.md`, `config_handler_test.lua`, and `test/config_dependency_test.lua`, which asserts the exact URL and fails if left behind. The `public_files` embed was re-vendored from the deployed 1.0.55 CDN and verified to be real JavaScript rather than an error body. It is byte-identical to the previous copy — `loading.js` did not change this release — so it carries no diff here. Web Host 1.0.55 is live on the CDN (module.js self-reports 1.0.55) and the `@wippy-fe` packages are published at 0.0.55, so this ref resolves.
Moves the `fe_facade_url` default, the Makefile's `WEB_HOST_CDN`, the README's documented default and sample payload, and the two test assertions that pin the expected default - all nine references, in lockstep, so the tests keep asserting the value the config actually ships. 1.0.56 adds the chat's `empty-state` slot and a `reason` on the `openArtifact` intent, and removes `presentation="standalone"`. An app that set that attribute keeps the embedded chat layout when this default moves; its visual half belongs in the element's `custom-css` prop. The CDN path this names is live only once `webcomponents-1.0.56` is deployed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Points the facade's
fe_facade_urldefault at Web Host 1.0.56, and carriesthe 1.0.55 bump that had not been pushed either — both facade CDN moves land
together here.
What changed
All nine references, moved in lockstep so the tests keep asserting the value the
config actually ships:
src/facade/_index.yaml— thefe_facade_urldefaultsrc/facade/Makefile—WEB_HOST_CDNsrc/facade/README.md— documented default and the sample payloadsrc/facade/config_handler_test.luaandsrc/facade/test/config_dependency_test.lua— the assertions that pin the expected defaultWhy 1.0.56 matters to consumers
1.0.56 adds the chat's
empty-stateslot and areasonfield on theopenArtifactintent, and removespresentation="standalone", which shippedin 1.0.55. An app that set that attribute keeps the embedded chat layout when
this default moves; the visual half of what it did belongs in the element's
custom-cssprop.Verification
The CDN path this names is live — every asset returns 200 and the deployed
managed-layout.jsreportsBUILD_VERSION:"1.0.56". The vendoredpublic/@wippy-fe/loading.jswas re-synced from the new path and came backbyte-identical to the 1.0.55 copy, so no vendored file changes here.
Note on release path
wippy/facade@0.6.37has already been published to the hub carrying thesevalues, via
wippy publishfromsrc/facaderather than the release-please →publish.ymltrain. The facade is therefore one version ahead of the othermodule folders until the next repo release.