docs: merge md files with cc-book#2178
Merged
Merged
Conversation
typfel
approved these changes
May 27, 2026
Member
|
@fewerner why are we pulling in mermaid? |
istankovic
requested changes
May 27, 2026
Member
istankovic
left a comment
istankovic
left a comment
There was a problem hiding this comment.
We should clarify why we need to pull in minified mermaid.
fewerner
force-pushed
the
felix/merge-docs-ccbook
branch
2 times, most recently
from
b930b9d to
1d04f14
Compare
istankovic
reviewed
May 28, 2026
istankovic
reviewed
May 28, 2026
Member
|
It would be nice if commit message of |
istankovic
reviewed
May 28, 2026
istankovic
approved these changes
May 28, 2026
Member
istankovic
left a comment
istankovic
left a comment
There was a problem hiding this comment.
Thanks, without vendored mermaid this looks much better!
fewerner
force-pushed
the
felix/merge-docs-ccbook
branch
4 times, most recently
from
c782d02 to
825bd84
Compare
This should have been removed when we switched from antora to mdbook
These files should not be part of the repo but installed once locally.
These files will be added when installing the mdbook dependencies to cc-book.
We reduce code duplication with a composite action. We also replace the curl commands here and instead use taiki-e/install-action which will call `cargo binstall`. We rely on this action across the whole project. There is no reason to do something else here.
We delete quite a lot of incorrect or redundant docs here. The naming conventions section can be dropped, as we don't want to maintain a style guide here and instead enforce our style through CI. I also delete some architecture sections that focused on mls implementation details rather than architecture. These are likely to change and don't add much value here.
With urbn these types translate to bigint.
There is no reason to include the readme here. `KEYSTORE_IMPLEMENTATION.md` conceptionally described the implementation but is no replacement for a module doc string.
fewerner
force-pushed
the
felix/merge-docs-ccbook
branch
from
825bd84 to
5daf73b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's new in this PR
This PR moves all docs files which are not Readme or docs entry point to the cc--book.
PR Submission Checklist for internal contributors
SQPIT-764feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.