refactor: PreKeyStore does not require mutable self references [WPB-25640]#57
Merged
Merged
Conversation
Requiring mutable access to the keystore for potentially mutating methods is logical for items which live in memory; I can't fault the developers for doing it this way. Unfortunately, real database abstractions tend towards hiding the mutability, and requiring it in this trait is blocking a refactor we'd like to accomplish. This trait is the only method on that type which requires mutability. So we're adjusting the trait.
Also we substantially simplify the actual implementation.
coriolinus
force-pushed
the
prgn/refactor/25640-prekeystore-not-mutable
branch
from
569bc6a to
4fc1771
Compare
istankovic
reviewed
Jun 3, 2026
istankovic
reviewed
Jun 3, 2026
coriolinus
force-pushed
the
prgn/refactor/25640-prekeystore-not-mutable
branch
from
fb28690 to
3b6a1a4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
SQPIT-764