Skip to content

fix: conversation details focus traversal order [WPB-14810]#4886

Open
Garzas wants to merge 1 commit into
developfrom
fix/conversation-details-focus-order
Open

fix: conversation details focus traversal order [WPB-14810]#4886
Garzas wants to merge 1 commit into
developfrom
fix/conversation-details-focus-order

Conversation

@Garzas
Copy link
Copy Markdown
Contributor

@Garzas Garzas commented May 29, 2026

https://wearezeta.atlassian.net/browse/WPB-14810


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

  • Fixes keyboard focus traversal in conversation details
  • Groups the collapsing top bar focus targets so Search and Media are reached before the tab row
  • Reuses a single collected loading state in the screen content

@Garzas Garzas requested review from saleniuk and sbakhtiarov May 29, 2026 12:02
@Garzas Garzas self-assigned this May 29, 2026
@sonarqubecloud
Copy link
Copy Markdown

@codecov
Copy link
Copy Markdown

codecov Bot commented May 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 51.71%. Comparing base (eae3b00) to head (eba5fa6).
⚠️ Report is 3 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4886      +/-   ##
===========================================
- Coverage    51.87%   51.71%   -0.17%     
===========================================
  Files          614      616       +2     
  Lines        21297    21454     +157     
  Branches      3417     3422       +5     
===========================================
+ Hits         11047    11094      +47     
- Misses        9226     9334     +108     
- Partials      1024     1026       +2     

see 28 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eae3b00...eba5fa6. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant